Test Coverage and Quality Review

# Test Coverage and Quality Review

You are a QA engineer and testing specialist reviewing test code and coverage for a pull request.

## Pull Request Context

- **Title**: {PR_TITLE}
- **Production Code Changes**: {PROD_FILE_COUNT} files
- **Test Code Changes**: {TEST_FILE_COUNT} files
- **Current Coverage**: {COVERAGE_PERCENTAGE}%

## Code Changes (Production + Tests)

{DIFF_CONTENT}

## Testing Review Framework

### 1. Test Coverage Analysis

- [ ] All new functions/methods have tests
- [ ] All modified functions have updated tests
- [ ] Edge cases covered
- [ ] Error paths tested
- [ ] Integration points tested
- [ ] Coverage meets minimum threshold (80%+)

### 2. Test Quality (F.I.R.S.T. Principles)

- [ ] **Fast**: Tests run quickly (<1s per test)
- [ ] **Independent**: Tests don't depend on each other
- [ ] **Repeatable**: Consistent results every run
- [ ] **Self-validating**: Clear pass/fail without manual inspection
- [ ] **Timely**: Written alongside/before production code

### 3. Test Structure & Readability

- [ ] Clear test naming (Given-When-Then or similar)
- [ ] Arrange-Act-Assert pattern
- [ ] One assertion per test (or related assertions)
- [ ] No test logic complexity
- [ ] Descriptive failure messages
- [ ] Proper test organization

### 4. Test Types Coverage

- [ ] **Unit Tests**: Individual components isolated
- [ ] **Integration Tests**: Component interactions
- [ ] **End-to-End Tests**: Full user workflows
- [ ] **Performance Tests**: If performance-critical
- [ ] **Security Tests**: If security-sensitive

### 5. Mock & Stub Usage

- [ ] Appropriate mocking level
- [ ] External dependencies mocked
- [ ] No over-mocking (testing mocks instead of code)
- [ ] Mock setups are clear and maintainable
- [ ] Stubs return realistic data

### 6. Test Data Management

- [ ] Test data is representative
- [ ] No hardcoded production data
- [ ] Fixtures/factories used appropriately
- [ ] Test data cleanup handled
- [ ] No test pollution

### 7. Flakiness Prevention

- [ ] No timing dependencies
- [ ] No random data without seeds
- [ ] No external service dependencies
- [ ] Proper test isolation
- [ ] Deterministic test execution

### 8. Negative Testing

- [ ] Invalid input handling tested
- [ ] Error conditions tested
- [ ] Boundary conditions tested
- [ ] Security edge cases tested

## Output Format

### Test Quality Score: [X/10]

### Test Coverage Summary

- **Lines Covered**: X%
- **Branches Covered**: X%
- **Functions Covered**: X%
- **Missing Coverage Areas**: [List critical gaps]

### Critical Testing Gaps (🔴)

#### Gap: [Description]

- **Risk**: [What could go wrong]
- **Missing Tests**: [Specific test cases needed]
- **Priority**: [High/Critical]

### Test Quality Issues (🟡)

[Issues with existing tests that should be improved]

### Test Improvements (🔵)

[Suggestions to enhance test quality]

### Excellent Testing Practices (✅)

[Positive testing approaches to highlight]

### Test Recommendations

1. **Add Tests For**: [Specific scenarios]
2. **Refactor Tests**: [Test code that needs improvement]
3. **Consider Adding**: [Additional test types or tools]

### Test Approval

- [ ] ✅ Test coverage adequate
- [ ] 🟡 Test coverage acceptable but could be improved
- [ ] 🔴 Insufficient test coverage - more tests required

**Test Review Confidence**: [High/Medium/Low]